Use faster mechanism for type checks against DOM nodes #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The
* `<node>.isA<HTMLInputElement>()` and
* `<node>.instanceOfString('HTMLInputElement')`
APIs are currently performing poorly, see [0].
Instead we use `<node>.instanceof(<constructor>)` with a cached value of
the looked up constructor. This results in 5-10x faster type checks in
dart2wasm.
[0] dart-lang/sdk#60344
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<node>.isA<HTMLInputElement>()and<node>.instanceOfString('HTMLInputElement')APIs are currently performing poorly, see [0].
Instead we use
<node>.instanceof(<constructor>)with a cached value of the looked up constructor.=> This results in 5-10x faster type checks in dart2wasm.
[0] dart-lang/sdk#60344