fix: better default serializer

schummar · Jan 23, 2025 · 4213413 · 4213413
1 parent b2b14de
commit 4213413
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/exporters/serializer.ts b/src/exporters/serializer.ts
@@ -0,0 +1,7 @@
+export function defaultSerializer(x: unknown): string | number | Date {
+  if (x instanceof Date || typeof x === 'number' || typeof x === 'string') {
+    return x;
+  }
+
+  return JSON.stringify(x);
+}
diff --git a/src/internalState/calcProps.ts b/src/internalState/calcProps.ts
@@ -2,6 +2,7 @@ import { useMemo } from 'react';
 import { useTableMemo } from '../hooks/useTableMemo';
 import { asString } from '../misc/helpers';
 import type { Column, Id, InternalColumn, InternalTableProps, TableProps } from '../types';
+import { defaultSerializer } from '../exporters/serializer';
 
 const noopParentId = () => undefined;
 
@@ -71,10 +72,7 @@ export function calcProps<T>(props: TableProps<T>): InternalTableProps<T> {
           `columns.${cacheKey}.renderCell`,
           renderCell ?? defaults?.renderCell ?? asString,
         ),
-        exportCell:
-          exportCell ??
-          defaults?.exportCell ??
-          ((x) => (x instanceof Date || typeof x === 'number' ? x : String(x))),
+        exportCell: exportCell ?? defaults?.exportCell ?? defaultSerializer,
         sortBy: (
           sortBy ??
           defaults?.sortBy ?? [