Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove installation of backends from 'test' extra #2373

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 27, 2023

Description

To be able to take advantage of PR #2340 in CI it requires the ability to select a subset of dependencies to install as well (c.f. Issue #2372). To do this, this PR decouples the installation of the test dependendies in the 'test' extra from the backends that are installed in the 'all' extra and now requires 'all' to be explicitly given.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove the 'all' extra from the 'test' extra installs and add 'all' to 
  the 'develop' extra.
* Add the 'all' extra to all install commands that also install the 'test' extra.

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions build Changes that affect the build system or external dependencies labels Oct 27, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a347f4) 98.28% compared to head (2a9532c) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2373   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4539     4539           
  Branches      803      803           
=======================================
  Hits         4461     4461           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.71% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.32% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

Merging this given no feedback, but we can iterate on revisions if there are future requests for changes.

@matthewfeickert matthewfeickert merged commit 78d9cc2 into main Nov 2, 2023
19 checks passed
@matthewfeickert matthewfeickert deleted the build/change-extras branch November 2, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant