-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve warnings for qmu and qmu_tilde for the set POI bounds #2390
Conversation
78d695a
to
25ecdfb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2390 +/- ##
==========================================
+ Coverage 96.29% 98.28% +1.98%
==========================================
Files 69 69
Lines 4539 4539
Branches 648 803 +155
==========================================
+ Hits 4371 4461 +90
+ Misses 128 45 -83
+ Partials 40 33 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lorenzennio. So this is good, but these log warnings are raised in the test stat APIs themselves, where there is no test_stat
kwarg, as the API is already the test stat. So I would suggest on a newline (as this will get long otherwsise) noting that if the user is calling from the pyhf.infer.mle
APIs or pyhf.infer.hypotest
this can be set via kwarg.
…I bounds (#2426) * Backport PR #2390 * Add Lorenz Gaertner to contributors list. Co-authored-by: Lorenz Gaertner <[email protected]>
@lorenzennio This fix is now out in |
Description
When running
we get a warning
and vice versa for POIs not bounded at 0.
But this should also tell you to set
test_stat="qtilde"
or (test_stat="q"
).Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: