Coverity Unused values Issues #5763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAFernandez
added
coverity
JohnAFernandez
added
the
sanitizer/stability
EatThePath
reviewed
Nov 6, 2023
Since we are explicitly setting the exact flag values. For coverity 1320526
Since it would be overwritten next line anyway. For coverity 1320527
For coverity 1523417
This was originally `glBlendFunc(GL_ONE, GL_ZERO);` `blendfunc_Value[0] = GL_ONE;` `blendfunc_Value[1] = GL_ZERO;` Marked by coverity 1523247
So that linters and coverity don't complain about the initial value being overwritten. Coverity 1320531
For coverity 1522980
In hud_lock_acquire_current_target, because we didn't need a pointer here, we needed a pointer of a pointer. For coverity 1522999
This is just another cleanup pointed out by coverity 1523154
This cleans up the code and keeps us from thinking that target_ship_obj is needed. This is a retail issue. Marked by coverity 1320528
JohnAFernandez
force-pushed
the
Unused-values
branch
from
1da3be5 to
2fca4e4
Compare
|
Game seems unaffected (as expected) from tests. |
JohnAFernandez
added
the
Waiting for Stable
Goober5000
removed
the
Waiting for Stable
Goober5000
previously approved these changes
Apr 12, 2025
Goober5000
reviewed
Apr 12, 2025
| @@ -719,7 +719,7 @@ void hud_do_lock_indicator(float frametime) | |||
| } | |||
| } | |||
|
|
|||
| void hud_lock_acquire_current_target(object *target_objp, ship_subsys *target_subsys) | |||
| void hud_lock_acquire_current_target(object *target_objp, ship_subsys **target_subsys) | |||
There was a problem hiding this comment.
This will now modify the source target subsys, which is obviously the intent of the function but didn't happen before now. Have the repercussions been checked?
Goober5000
dismissed
their stale review
Putting this on hold until we have a more complete understanding of the hud_lock_acquire_current_target consequences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some coverity issues in the "Unused Values" category. In draft because I need to see this patch's effect on targeting large ship subsystems.