Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Line Height for Footnote Block #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stormbreath
Copy link
Contributor

@stormbreath stormbreath commented Feb 22, 2025

The block of footnotes at the bottom of the page does not wrap the footnotes into either a <li> or <p> element, causing it to not inherit the line-height: 1.5 that paragraphs get by default. This applies that line-height argument to both the footnotes at the bottom of the page and the to the footnote blocks themselves, so it is not compressed.

image

Footnotes of SCP-3477 at present, in which footnote two gets the line-spacing because of the multiple paragraphs in the footnote, but in which the other footnotes do not have the line spacing.

image

Footnotes of SCP-3477 after line-spacing applied to .footnote-footer.

image

Current implementation of a footnote hovertip.

image

Footnote after change.

@stormbreath stormbreath requested a review from emmiegit February 22, 2025 01:04
@emmiegit
Copy link
Member

Add screenshots of the change for bibliography items and it's good to merge imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants