Rename keyboard IME and view

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-Android's Code of Conduct

Description

There are two legacy names that should be changed in the project:

• SimpleKeyboardIME (from the original project)
• MyKeyboardView (should be named better)
• MyKeyboard (should be named better)

The question is, what should they be named to? BaseKeyboardIME and BaseKeyboardView?

Contribution

Happy to discuss and review as needed 😊

[saurav0523]

can i start working on it

[saurav0523]

oe you need to assigned me

[andrewtavis]

Sounds good, @saurav0523! Thanks for the offer to help :) Let us know if you need some assistance here.

[andrewtavis]

Hi @saurav0523 👋 Checking in with you here. Is there anything we can do to support you with this?

[saurav0523]

Hi @andrewtavis thank you for assigned me.. as of now I'm bit busy for that just need some time.. Will start working on it after some days. Thank you

[andrewtavis]

All good, @saurav0523! Let us know if we can help :)

[andrewtavis]

Hey @saurav0523 👋 Checking in to see if there's anything that we can do to support here :) Please let us know if there's something we can do to help!

@angrezichatterbox: The renames I'm thinking of now would be:

• SimpleKeyboardIME -> KeyboardIME
• MyKeyboardView -> KeyboardView
• MyKeyboard -> KeyboardBase

How do the above changes sound to you?

[Linfye]

Maybe SimpleKeyboadIME to LanguageKeyboardIME or GeneralKeyboardIME?

And the names you suggest all start with the word Keyboard. Are you doing this on purpose? What's the reason behind it?Maybe they'll be easier to be found or sorted this way? 😁

[angrezichatterbox]

@angrezichatterbox: The renames I'm thinking of now would be:

• SimpleKeyboardIME -> KeyboardIME
• MyKeyboardView -> KeyboardView
• MyKeyboard -> KeyboardBase

How do the above changes sound to you?

These sound nice. We could name the KeyboardIME as GeneralKeyboardIME as well as suggested by @Linfye

Sorry for the delay. I missed this tag.

[andrewtavis]

I'm also good with GeneralKeyvoardIME :) @Linfye, would you have interest in making the changes?

[Linfye]

Certainly, but maybe in few days. I am busy with some college work these days. :)

[andrewtavis]

Sounds great! Good luck with the college work :) I'll assign you and you can start when you're ready 😊

[andrewtavis]

@saurav0523, you'd also be welcome to still work on this. Please let us know if you have time!

[saurav0523]

@andrewtavis heyy, I'm really sorry for the delay. I hope you understand this December month generally we are having our college end semester exams and all due to this Messed up. I'm not able to focus on this work but just give me few more weeks I'll give update on this. I really want to work on this issue

[andrewtavis]

Sounds good, @saurav0523! Let us know when you're able to start and we'll check in at the end of the month if we haven't heard from you 😊

@Linfye, let's hold up on this for now on your end :) Thanks for your willingness to help!

[Linfye]

OK :)

[saurav0523]

Sure

…

On Mon, 9 Dec, 2024, 4:00 am Linfye, ***@***.***> wrote: OK :) — Reply to this email directly, view it on GitHub <#223 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXT7EQHU55TCL25KONM2MI32ETB7VAVCNFSM6AAAAABQP57AC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGQYTGMJVG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[akshayw1]

Is this completed?

[andrewtavis]

@saurav0523 is still assigned this, @akshayw1 :)

@saurav0523, could you give a quick update on whether you'd be able to get to this in the next two weeks?

[andrewtavis]

Closed by #294 :) Thanks for picking this up and for the work in defining the solution heree, @Linfye! 🚀

@saurav0523: You'd be welcome to pick up another issue at some point, but we really needed to get this in so that we wouldn't be dealing with potential merge conflicts for the many changes to the keyboard on the way. Hope we can work with you again in the future! 😊

@akshayw1: I'd suggest bringing these changes in for your PR for #267 as there could be conflicts given the new naming criteria :)