Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Keyboard IME #294

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

Linfye
Copy link
Collaborator

@Linfye Linfye commented Jan 7, 2025

Contributor checklist


Description

I renamed the code variable names and XML file names according to this rule.

  • SimpleKeyboardIME -> GeneralKeyboardIME
  • MyKeyboardView -> KeyboardView
  • MyKeyboard -> KeyboardBase

After my initial testing, the app can run normally currently.

Related issue

Copy link

github-actions bot commented Jan 7, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Linfye Linfye requested a review from andrewtavis January 7, 2025 06:18
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for picking this up and the the initiative in deciding what to rename things, @Linfye! Really great to be taking this step as a project away from the original codebase 😊

Let us know if one of the new issues is appealing for you to pick up!

@andrewtavis andrewtavis merged commit 780870c into scribe-org:main Jan 7, 2025
4 checks passed
@andrewtavis andrewtavis mentioned this pull request Jan 7, 2025
2 tasks
@Linfye Linfye deleted the rename-keyboard-IME branch January 7, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants