Implemented Language Based Settings #63
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
|
All this is really great, @angrezichatterbox! One thing that I'm noticing is that the dark mode toggle is a bit weird 🤔 It's light mode when I first load the app, but then the toggle is technically on for dark mode. Then when I click it first nothing happens, then clicking it again it goes to the left, and then clicking it again it goes to the right. This is the only toggle that has this issue. Do you want to take a look and then we can merge this in after. Thanks so much! 🚀 |
I have fixed the dark mode toggle. :) |
There was a problem hiding this comment.
Thanks for the quick reaction to the feedback and another great contribution, @angrezichatterbox! Really is coming along now that we have two screens of the app looking like they do! I'll check in with you on next steps 😊
c916c4d Update xcstrings and de/sv strings given new localizations 0a58b1c Merge pull request #75 from weblate/weblate-scribe-scribe-i18n 6b43bfd Translated using Weblate (Swedish) f193e49 Translated using Weblate (German) 4f60287 Translated using Weblate (Swedish) 1422f5e Convert Korean JSON to xcstrings and Android values 718ab45 Update all xcstrings and strings files given new localizations 8c13530 Merge pull request #73 from yerimmii/ko-json bc78915 Create ko.json 3f2a3de Minor edit to .gitignore for spacing e40d892 Merge pull request #72 from axif0/bangla 1afc6ea Creating Bangla localization 23c56ed Merge pull request #70 from KesharwaniArpita/ArpitaContributionsMarathi d49ed68 Create string.xml 7dc4b73 Create mr.json (Marathi) 6bc6502 Merge pull request #69 from axif0/work 933237d Update pr_maintainer_checklist.yaml fa75400 Merge pull request #68 from OmarAI2003/MSA-internationalization 329ad53 Translate from en to ar c81e3a1 Add Arabic translation file (ar.json) for localization support 45bce87 Merge pull request #66 from OmarAI2003/improve-android-convert-str-to-json b774027 Minor spacing and removing permissions error a3eeda1 Merge pull request #67 from weblate/weblate-scribe-scribe-i18n c67255b Translated using Weblate (Spanish) 7054971 fix: add check for missing values_directory a90a040 Error handling for file read and write operations 9295291 Use a single variable for the 'jsons' folder path and add error handling for missing 'jsons' folder. 5e85b16 Merge pull request #64 from OmarAI2003/improve-android-convert-jsons-to-strings 94482ef Added docstrings to Android string conversion functions 2a7b35b for the recently supported language: adding the 'hi' language folder generated by the script to prevent 'directory not found' errors when testing the reverse conversion (JSON to strings). 13a4849 small fix to the lang_dir e5ca964 Refactor: Pre-load language JSON files before generating strings.xml files f8ffe63 Use a single variable for the 'jsons' folder path and add error handling for missing 'jsons' folder. 7dbeaa1 Merge pull request #62 from OmarAI2003/improve-convert-jsons-to-xcstrings a3e5fbf Minor edits to script spacing and comments 5fb2fc5 Merge pull request #63 from KesharwaniArpita/ArpitaContributionsHindi fd91955 Create hi.json 9fcc0de fix: update inline comments to start with lowercase as per style guide. 8925a4b Rename variable for improved clarity aee58c0 Add error handling for missing base language file d41c8eb Remove automatic creation of the 'jsons' folder d811de7 Optimize performance by pre-loading language JSON files 81da648 Refactor: Use a single variable for the 'jsons' folder path and ensure it exists. f354bb4 Fix file handling: Use context managers to ensure safe reading and writing of files. 13d52f2 Merge pull request #58 from OmarAI2003/improve-convert-xcstrings-to-jsons 8b13ee6 Fix to en.json being written rather than en-US + minor edits 2a7e03d Merge pull request #61 from weblate/weblate-scribe-scribe-i18n f0abf87 Translated using Weblate (French) 6c4acae Merge pull request #60 from OmarAI2003/fix-typo-in-readme.md d30380a Revert: Move Localizable.xcstrings back to original location 46a68da moved Localizable.xcstrings again where it was as andrew told me d426a4b Fix typo in README: Changed 'an tools' to 'tools' 0d48009 made the changes as per the feedback and added Localizable.xcstrings to 'jsons' directory 42e76dd Improve language handling and ensure directory creation b1ccff7 Refactor: Use context manager for writing JSON files to ensure proper file handling. 5b97d83 Add JSON loading error handling in convert_xcstrings_to_jsons.py 32b8f70 Improve file handling in convert_xcstrings_to_jsons.py 7536be6 Update app menu headings to not include second word caps c286cf2 Merge pull request #50 from weblate/weblate-scribe-scribe-i18n 3038710 Translated using Weblate (Spanish) b80ddc7 Translated using Weblate (Spanish) faf7ce3 Various fixes of strings and adding conjugate keys 1eb7d47 Minor update to readme headers 04574f8 Remove unused keys and fix colon spacing 8492a7a Make sure that application names are not localized 0ac6710 Merge pull request #48 from weblate/weblate-scribe-scribe-i18n 80708cb Translated using Weblate (Spanish) dd15564 Merge pull request #47 from weblate/weblate-scribe-scribe-i18n f05f74d Translated using Weblate (Spanish) git-subtree-dir: app/src/main/assets/i18n git-subtree-split: c916c4d563c2cf2ba8735494a76e97a6a1c912c2
Contributor checklist
Description
The pull request implemented Language-based Settings for the enabled language keyboards. I have also changed the min and target sdk and upgraded gradle to 8.5.2 to enable navigation features to app locale settings. I have also moved the files to the Android Studio-generated package.
Related issue