-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Use Fragments for navigation #74
feat:Use Fragments for navigation #74
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Nice, @angrezichatterbox :) Only one file with merge conflicts! |
Yes. I will be fixing it within some time and I will comment here when its ready for review :). |
Perfect, thanks so much! I'll plan to bring it in later today if you send the next commit :) |
7662769
to
0f3ec42
Compare
I have made the necessary changes. The PR is ready for review. :) |
Ok the other PR is in, @angrezichatterbox :) Two files have conflicts, but then I'll bring this in once they're fixed 😊 Thanks for the coordination here! |
5d511eb
to
26a6032
Compare
Let me know when it's ready for a review, @angrezichatterbox :) |
It is ready for review now. :) I have checked for any bugs that occurred and have fixed whatever I could see. If there are any more that this PR has I will be fixing it right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working really really well, @angrezichatterbox! Such an improvement on the experience. Thanks for looking into how we can improve it and setting everything up!
One note: We don't have a back button in sub menus right now. I'll make an issue for that 😊
Contributor checklist
Description
Related issue