Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Use Fragments for navigation #74

Merged

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The pull request replaces activities with fragments for better navigation. A view pager has been used to make the swipe gestures for movements similar to Scribe-iOS. Through the pull request, the Bottom navigation bar is not being reconstructed every time the user changes the page.

Related issue

Copy link

github-actions bot commented Aug 29, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Nice, @angrezichatterbox :) Only one file with merge conflicts!

@angrezichatterbox
Copy link
Member Author

Nice, @angrezichatterbox :) Only one file with merge conflicts!

Yes. I will be fixing it within some time and I will comment here when its ready for review :).

@andrewtavis
Copy link
Member

Perfect, thanks so much! I'll plan to bring it in later today if you send the next commit :)

@angrezichatterbox angrezichatterbox force-pushed the Use-Fragments-For-Navigation branch from 7662769 to 0f3ec42 Compare August 29, 2024 09:09
@angrezichatterbox
Copy link
Member Author

I have made the necessary changes. The PR is ready for review. :)

@andrewtavis andrewtavis mentioned this pull request Aug 29, 2024
1 task
@andrewtavis
Copy link
Member

Ok the other PR is in, @angrezichatterbox :) Two files have conflicts, but then I'll bring this in once they're fixed 😊 Thanks for the coordination here!

@angrezichatterbox angrezichatterbox force-pushed the Use-Fragments-For-Navigation branch from 5d511eb to 26a6032 Compare August 30, 2024 05:01
@andrewtavis
Copy link
Member

Let me know when it's ready for a review, @angrezichatterbox :)

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Aug 30, 2024

Let me know when it's ready for a review, @angrezichatterbox :)

It is ready for review now. :)

I have checked for any bugs that occurred and have fixed whatever I could see. If there are any more that this PR has I will be fixing it right away.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working really really well, @angrezichatterbox! Such an improvement on the experience. Thanks for looking into how we can improve it and setting everything up!

One note: We don't have a back button in sub menus right now. I'll make an issue for that 😊

@andrewtavis andrewtavis merged commit a41cbb9 into scribe-org:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants