Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German indefinite articles to case-declension tables #303

Closed
2 tasks done
andrewtavis opened this issue May 12, 2023 · 4 comments · Fixed by #306
Closed
2 tasks done

Add German indefinite articles to case-declension tables #303

andrewtavis opened this issue May 12, 2023 · 4 comments · Fixed by #306
Assignees
@lucastronova
Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 12, 2023 •
edited
Loading

Terms

Description

As a part of some of the article selections that we'll be doing in #302 we'd need to also include the indefinite articles for German into the case-declension tables. This would require the values first being included in LanguageKeyboards/German/DECommandVariables.swift and then adding them to the switch declension display ordering in the same file. We'd also need to rename the current articles as definite pronouns rather than just pronouns so that there's a distinction. After this we can add the needed code into the declension display functions to get it all working correctly 😊

Contribution

I'll work on this soon to prepare to work on #302 or am also happy to support :)
@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -next release- Included in the next release labels May 12, 2023
@andrewtavis andrewtavis added the good first issue Good for newcomers label May 12, 2023
@andrewtavis
Copy link
Member Author

Note that this is also a good first issue if someone has interest :) Happy to direct someone in how to add all this information in in the right places 😊

lucastronova added a commit to lucastronova/Scribe-iOS that referenced this issue May 21, 2023
@lucastronova
Add indefinite pronouns (DE)
0167d9f 
Also renamed what were 'pronouns' to 'definite pronouns' for specificity

Addressing scribe-org#303
lucastronova added a commit to lucastronova/Scribe-iOS that referenced this issue May 21, 2023
@lucastronova
Disable plural option for indefinite pronouns (DE)
7080429 
also for scribe-org#303

Causes a small graphical bug when switching from the indefinite pronouns to the definite pronouns
@lucastronova lucastronova mentioned this issue May 21, 2023
Merged
2 tasks
@lucastronova
Copy link
Contributor

I have a PR open for this issue (#306)

@andrewtavis
Copy link
Member Author

Thank you, @lucastronova! Will get to it soon :) Really appreciate the help with this 😊

@andrewtavis andrewtavis linked a pull request May 26, 2023 that will close this issue
Add indefinite pronouns #306
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board May 26, 2023
andrewtavis added a commit that referenced this issue May 26, 2023
@andrewtavis
#303 unhide but disable BR declension btn during certain cases
06bc3ae
@andrewtavis
Copy link
Member Author

06bc3ae does the change that I mentioned in the PR, @lucastronova :) Thanks again for your work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucastronova lucastronova

Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add indefinite pronouns lucastronova/Scribe-iOS
2 participants
@andrewtavis @lucastronova