Add indefinite pronouns #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed what were 'pronouns' to 'definite pronouns' for specificity Addressing scribe-org#303
also for scribe-org#303 Causes a small graphical bug when switching from the indefinite pronouns to the definite pronouns
|
Thank you, @lucastronova! Really appreciate your interest in Scribe :) Can I ask you to write in #303 so I can assign you? I'll get to this review soon. Quite busy making issues for Scribe's participation in Google Summer of Code at the moment :) |
2 tasks
andrewtavis
approved these changes
May 26, 2023
There was a problem hiding this comment.
This is a really great first contribution, @lucastronova 😊 Sorry that it's taken me so long to review it. Life's quite busy these days. I'm going to make a minor change to just make the BR button not be user interactable as I don't like that it's disappearing, but aside from that this is all really wonderful work :) :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Disclaimer: I have not contributed to open source before so I am not sure I did everything right.
First one is unchecked because I am not sure what it means. I could not find another branch besides 'main'.
Description
Added German indefinite pronouns. Disabled the 'plural' button for the indefinite pronouns due to lack of an indefinite plural pronoun in German.
Tested by building the project and seeing that it worked (not sure how else I should check it)
Related issue