-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feat)/reenable 1559 #578
(Feat)/reenable 1559 #578
Conversation
This reverts commit 3fe4fdf.
…t/conf-for-hard-fork
…thereum into feat/reenable-1559
…t/conf-for-hard-fork
…thereum into feat/reenable-1559
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will this be merged soon?will be helpful for circuit side integration and testing. |
The base branch was changed.
core/state_transition.go
Outdated
// Make sure that transaction gasFeeCap is greater than the baseFee (post london) | ||
if st.evm.ChainConfig().IsLondon(st.evm.Context.BlockNumber) { | ||
// Make sure that transaction gasFeeCap is greater than the baseFee (post Banach) | ||
if st.evm.ChainConfig().IsBanach(st.evm.Context.BlockNumber) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
London has already happened on Scroll mainnet and Scroll Sepolia (meaning that IsLondon
is already true). So changing this here would be a breaking change, it would change the state transition function, and lead to l2geth
not being able to sync the chain.
I think the safest approach is to leave |
Closing for #634. |
1. Purpose or design rationale of this PR
Currently Scroll does not support EIP-1559 transactions, fee markets, block fields, and opcodes (BASEFEE). We want to enable this as part of the next hard fork.
https://app.asana.com/0/1202293017617135/1205896809138440/f
Testing
EIP-1559 transactions and
baseFeePerGas
Banach
fork activated in block number 15custom error: EIP-1559 not activated
getBlockByNumber
didn't return fieldbaseFeePerGas
at allbaseFeePerGas
that changesBASEFEE
opcodesetBaseFee
method beforeBanach
block. It returned error(code: -32000, message: invalid opcode: BASEFEE, data: None)
setBaseFee
method after fork activation and checked the stored value witheth_getStorageAt
. The value stored inbasefee
variable was the same asbaseFeePerGas
of corresponding block2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?