-
Notifications
You must be signed in to change notification settings - Fork 624
feat(blob-uploader): add arweave sender #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yiweichi
wants to merge
9
commits into
develop
Choose a base branch
from
feat-blob-upload-arweave
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
343a1bb
fix: aws s3 config
yiweichi 2cd9217
chore: auto version bump [bot]
yiweichi 465c36e
feat: temporarily disable codec_version check
yiweichi 6cc6a45
feat: temporarily disable codec_version check
yiweichi c68a4a0
feat: temporarily disable codec_version check
yiweichi e50675f
fix: InsertOrUpdateBlobUpload
yiweichi 7eb5212
fix: codec v2 special handle
yiweichi 9780bcb
feat(blob-uploader): add arweave sender
yiweichi fe58a30
feat(blob-uploader): add arweave sender
yiweichi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
database/migrate/migrations/00028_add_transaction_hash_to_blob_upload.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| -- +goose StatementBegin | ||
|
|
||
| ALTER TABLE blob_upload | ||
| ADD COLUMN tx_hash VARCHAR DEFAULT '', | ||
|
|
||
|
|
||
| CREATE INDEX idx_blob_upload_transaction_hash ON blob_upload(tx_hash); | ||
|
|
||
| -- +goose StatementEnd | ||
|
|
||
| -- +goose Down | ||
| -- +goose StatementBegin | ||
|
|
||
| DROP INDEX IF EXISTS idx_blob_upload_tx_hash; | ||
|
|
||
| ALTER TABLE IF EXISTS blob_upload | ||
| DROP COLUMN IF EXISTS tx_hash; | ||
|
|
||
| -- +goose StatementEnd | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mismatch between up/down migration breaks rollback
UPcreates the index asidx_blob_upload_transaction_hash, but theDOWNsection tries to dropidx_blob_upload_tx_hash. A rollback will therefore error out, leaving the column and index in place.🤖 Prompt for AI Agents