Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [phase1] remove eth-types #43

Merged
merged 13 commits into from
Sep 4, 2024
Merged

refactor: [phase1] remove eth-types #43

merged 13 commits into from
Sep 4, 2024

Conversation

lightsing
Copy link
Member

@lightsing lightsing commented Sep 3, 2024

revm repo needs update after this merge.

crates/primitives/src/lib.rs Outdated Show resolved Hide resolved
@lightsing lightsing changed the title feat: remove eth-types refactor: stage1 remove eth-types Sep 4, 2024
@lightsing lightsing changed the title refactor: stage1 remove eth-types refactor: [phase1] remove eth-types Sep 4, 2024
@lightsing lightsing marked this pull request as ready for review September 4, 2024 04:43
@lispc
Copy link
Contributor

lispc commented Sep 4, 2024

  1. no need to add both {v1,v2}_bytecode.{bin,txt} all? txt and bin are same thing actually?
  2. need to update README related to '--disable-checks'?

lispc
lispc previously approved these changes Sep 4, 2024
@lightsing
Copy link
Member Author

  1. no need to add both {v1,v2}_bytecode.{bin,txt} all? txt and bin are same thing actually?
  2. need to update README related to '--disable-checks'?

add both file is for others can verify that they are same thing, as it's originally hex encoded.

@lightsing lightsing merged commit 97a1900 into master Sep 4, 2024
5 checks passed
@lightsing lightsing deleted the feat/vendor branch September 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants