-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-scylla-node: auto-detect NVMe: only use non-mounted disks. #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eca0278
to
a9d2694
Compare
a9d2694
to
ae5f053
Compare
igorribeiroduarte
previously approved these changes
Oct 23, 2024
misbehaves on md0 with multiple nvmes |
ae5f053
to
c86cfd5
Compare
tarzanek
reviewed
Nov 5, 2024
c86cfd5
to
7debd91
Compare
What do you mean exactly, @tarzanek ? |
vladzcloudius
requested changes
Jan 27, 2025
b352844
to
939af5f
Compare
NVMe disks should only be selected that are not in use, which should be the case when they are not mounted. Fixes scylladb#407
939af5f
to
2bfb040
Compare
vladzcloudius
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMe disks should only be selected that are not in use, which should be the case when they are not mounted.
Fixes #407