Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla_node: pass -Dcom.scylladb.apiPort=10000 when running nodetool #559

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

tchaikov
Copy link
Contributor

this pass the setting of "api_port" to nodetool-wrapper, so that it can override the "-p" option with the port number. otherwise "scylla nodetool" would not be able to access the API service by connecting to the JMX server.

@tchaikov tchaikov requested review from denesb and fruch February 11, 2024 04:05
this pass the setting of "api_port" to nodetool-wrapper, so that it
can override the "-p" option with the port number. otherwise "scylla
nodetool" would not be able to access the API service by connecting
to the JMX server.

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov tchaikov force-pushed the scylla-node-pass-api-port-to-nodetool branch from 8b11255 to eda387b Compare February 11, 2024 04:13
@tchaikov
Copy link
Contributor Author

the change on the nodetool side can be found at scylladb/scylla-tools-java#380

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit df176b3 into scylladb:next Feb 12, 2024
@tchaikov tchaikov deleted the scylla-node-pass-api-port-to-nodetool branch February 12, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants