ccmlib/scylla_node.py: fix get_env() for non-cassandra nodes #624
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ef455c changes get_env() to return empty env for scylla nodes, as the native tools do not need any environment variables, unlike the previous java ones which we are about to drop. This however broke cqlsh, which needs the current environment to work correctly, but returning empty {} as currently happens resets the environment vars. Fix this by returning a clone of the current env, instead of reseting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0ef455c changes get_env() to return empty env for scylla nodes, as the native tools do not need any environment variables, unlike the previous java ones which we are about to drop. This however broke cqlsh, which needs the current environment to work correctly, but returning empty {} as currently happens resets the environment vars.
Fix this by returning a clone of the current env, instead of reseting it.