[cloud images] rename build_id to creation_timestamp tag
#523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benipeled
reviewed
May 2, 2024
packer/build_image.sh
Outdated
| @@ -76,8 +76,8 @@ while [ $# -gt 0 ]; do | |||
| shift 2 | |||
| ;; | |||
| "--build-id") | |||
There was a problem hiding this comment.
If the build-id renamed everywhere, change it here as well
There was a problem hiding this comment.
we can completely remove it as we now use date as default
benipeled
previously approved these changes
May 2, 2024
As part of my work in scylladb/scylla-pkg#3827, i need to delete old Azure images based on creation date, it seems that Azure doesn't have this information (make no sense), to overcome this we should have a creation_timestamp date tag so we can use. Also noticed that we don't really use the `build_id` tag, so replacing it for all cloud images and make it internal parameter
Annamikhlin
approved these changes
May 2, 2024
|
Waiting for scylladb/scylla-cluster-tests#7397 |
This was merged. Verified again with https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/next-machine-image/319/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my work in https://github.com/scylladb/scylla-pkg/issues/3827, i need to delete old Azure images based on creation date, it seems that Azure doesn't have this information (make no sense), to overcome this we should have a creation_timestamp date tag so we can use.
Also noticed that we don't really use the
build_idtag, so replacing it for all cloud images