Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRestoreSchemaVersionedIntegration is flaky #4246

Closed
VAveryanov8 opened this issue Feb 11, 2025 · 0 comments · Fixed by #4247
Closed

TestRestoreSchemaVersionedIntegration is flaky #4246

VAveryanov8 opened this issue Feb 11, 2025 · 0 comments · Fixed by #4247
Assignees
@Michal-Leszczynski
Labels
flake

Comments

@VAveryanov8
Copy link
Collaborator

First time error occurred in PR #4213

Full test log: FlakyTest.zip

Log message:

    service_restore_integration_test.go:1146: No files to be corrupted, firstCorrupt: 0, bothCorrupt: 0, secondCorrupt: 0
--- FAIL: TestRestoreSchemaVersionedIntegration (11.22s)

Re-running the test resolved the issue.
@Michal-Leszczynski Michal-Leszczynski self-assigned this Feb 11, 2025
Michal-Leszczynski added a commit that referenced this issue Feb 11, 2025
@Michal-Leszczynski
fix(restore_test): skip unintended CQL schema tests
d6793d6 
This commit adds skipCQLSchemaTestAssumingSSTables helper method
which allows to skip the CQL schema tests which were intended
just for the SSTAble schema restore. Example of such tests:
- restoreWithAgentRestart
- restoreWithResume
- restoreWithVersions
- restoreAlternator

Those tests were "passing" before by accident and that's
why they weren't skipped in the past. They are also not
that interesting for CQL schema restore, which just
applies saved CQL statements.

It also rephrases some comments so that it's clear
when a schema test should be skipped and for what
reason.

Fixes #4246
@Michal-Leszczynski Michal-Leszczynski mentioned this issue Feb 11, 2025
Merged
Michal-Leszczynski added a commit that referenced this issue Feb 12, 2025
@Michal-Leszczynski
fix(restore_test): skip unintended CQL schema tests (#4247)
61e584e 
This commit adds skipCQLSchemaTestAssumingSSTables helper method
which allows to skip the CQL schema tests which were intended
just for the SSTAble schema restore. Example of such tests:
- restoreWithAgentRestart
- restoreWithResume
- restoreWithVersions
- restoreAlternator

Those tests were "passing" before by accident and that's
why they weren't skipped in the past. They are also not
that interesting for CQL schema restore, which just
applies saved CQL statements.

It also rephrases some comments so that it's clear
when a schema test should be skipped and for what
reason.

Fixes #4246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michal-Leszczynski Michal-Leszczynski

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip unintended CQL schema tests scylladb/scylla-manager
2 participants
@VAveryanov8 @Michal-Leszczynski