Skip unintended CQL schema tests #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds skipCQLSchemaTestAssumingSSTables helper method which allows to skip the CQL schema tests which were intended just for the SSTAble schema restore. Example of such tests: - restoreWithAgentRestart - restoreWithResume - restoreWithVersions - restoreAlternator Those tests were "passing" before by accident and that's why they weren't skipped in the past. They are also not that interesting for CQL schema restore, which just applies saved CQL statements. It also rephrases some comments so that it's clear when a schema test should be skipped and for what reason. Fixes #4246
Michal-Leszczynski
requested review from
karol-kokoszka and
VAveryanov8
as code owners
karol-kokoszka
approved these changes
Feb 11, 2025
VAveryanov8
approved these changes
Feb 12, 2025
Michal-Leszczynski
deleted the
ml/fix-restore-schema-sstable-test-skip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds skipCQLSchemaTestAssumingSSTables helper method which allows to skip the CQL schema tests which were intended just for the SSTAble schema restore. Example of such tests:
Those tests were "passing" before by accident and that's why they weren't skipped in the past. They are also not that interesting for CQL schema restore, which just applies saved CQL statements.
It also rephrases some comments so that it's clear when a schema test should be skipped and for what
reason.
Fixes #4246