Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RSA key size configurable in operator command #2360

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Make RSA key size configurable in operator command #2360

merged 1 commit into from
Mar 10, 2025

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Feb 3, 2025 •
edited
Loading

Description of your changes: This PR makes RSA key size configurable in the operator command. Changes in CI scripts have to go separately: #2360 (comment).

Prerequisite for #2474.

Which issue is resolved by this Pull Request:
Resolves #

/kind machinery
/priority important-soon
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #

/kind flake
/priority important-soon
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2025
@rzetelskik rzetelskik changed the title [WIP] Make RSA key size configurable and use 1024 bits in E2E CI jobs by default [WIP] Make RSA key size configurable Feb 5, 2025
@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@rzetelskik rzetelskik changed the title [WIP] Make RSA key size configurable [WIP] Make RSA key size configurable in operator command Feb 5, 2025
@rzetelskik
Copy link
Member Author

rzetelskik commented Feb 5, 2025 •
edited
Loading

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest a673d60 link true /test e2e-gke-release-script-latest
Full PR test history. Your PR dashboard.

release-script job was failing as it's using the latest image which was missing the changes being introduced in this PR, so I had to split the changes in the scripts to a separate one: #2474

@rzetelskik rzetelskik mentioned this pull request Feb 13, 2025
Closed
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Feb 28, 2025 •
edited
Loading

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest a673d60 link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-multi-datacenter-parallel 796e98f link true /test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rzetelskik rzetelskik changed the title [WIP] Make RSA key size configurable in operator command Make RSA key size configurable in operator command Mar 10, 2025
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@rzetelskik
Copy link
Member Author

/cc zimnx mflendrich
See #2474 (comment) for rationale.

@rzetelskik rzetelskik added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. and removed kind/flake Categorizes issue or PR as related to a flaky test. labels Mar 10, 2025
@rzetelskik rzetelskik mentioned this pull request Mar 10, 2025
Merged
zimnx
zimnx approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 4c0fcbd into scylladb:master Mar 10, 2025
12 checks passed
@rzetelskik rzetelskik deleted the rkc-flake branch March 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@mflendrich mflendrich Awaiting requested review from mflendrich

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzetelskik @zimnx