Implement (derive) Debug for MaybeUnset #1199
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
muzarski
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
We will probably merge it after #1198 so @Lorak-mmk doesn't have to resolve the conflicts while working on it
stanislav-tkach
force-pushed
the
implement-debug-for-maybe-unset
branch
from
a490744 to
846f595
Compare
Thanks for reminder. @Lorak-mmk can we merge this? |
Lorak-mmk
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we have multiple structures that derive
SerializeRowand we often want to print them, but asMaybeUnsetdoesn't implementDebugwe are forced to manually implement it.Pre-review checklist
./docs/source/.Fixes:annotations to PR description.