Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes #1209

Merged
merged 3 commits into from
Feb 9, 2025
Merged

CI fixes #1209

merged 3 commits into from
Feb 9, 2025

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Feb 9, 2025

This PR prepares CI for our upcoming hackathon by enabling CI to run on PRs to any branch.
It also fixes a small issue: docs pages would not be built for 1.x version.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

There isn't really any good reason to restrict PR CI to specific branches.
Allowing all will let us to cooperate on some longer-lived branches.
Our tags always contains full version number, there is no reason to
allow anything else.
If we released 1.0 now, docs for it would not be published.
@Lorak-mmk Lorak-mmk changed the title Pr branches CI fixes Feb 9, 2025
Copy link

github-actions bot commented Feb 9, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: d2463c0

@Lorak-mmk Lorak-mmk merged commit 43f758f into scylladb:main Feb 9, 2025
11 checks passed
@Lorak-mmk Lorak-mmk deleted the pr-branches branch February 10, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants