Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for {query,execute}_iter API #1216

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Add tests for {query,execute}_iter API #1216

merged 2 commits into from
Feb 11, 2025

Conversation

sylwiaszunejko
Copy link
Contributor

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 69290df

@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch 2 times, most recently from 0dfb164 to 4b6fab3 Compare February 10, 2025 16:54
muzarski
muzarski reviewed Feb 10, 2025
View reviewed changes
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from 4b6fab3 to e1b2a60 Compare February 11, 2025 09:02
@sylwiaszunejko
Copy link
Contributor Author

@muzarski I addressed your comments and moved the file to tests/integration as it doesn't need ccm

@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from e1b2a60 to 4bf8e6e Compare February 11, 2025 09:05
@sylwiaszunejko sylwiaszunejko marked this pull request as ready for review February 11, 2025 09:05
@wprzytula wprzytula requested a review from muzarski February 11, 2025 09:24
wprzytula
wprzytula requested changes Feb 11, 2025
View reviewed changes
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from 4bf8e6e to b88e1e6 Compare February 11, 2025 10:13
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from b88e1e6 to 860f7ba Compare February 11, 2025 10:15
wprzytula
wprzytula reviewed Feb 11, 2025
View reviewed changes
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from 860f7ba to f42cc93 Compare February 11, 2025 10:42
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from f42cc93 to e947a47 Compare February 11, 2025 12:29
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_query_execute_iter branch from e947a47 to 69290df Compare February 11, 2025 12:34
@wprzytula wprzytula merged commit 74be1ef into scylladb:branch-hackathon Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wprzytula wprzytula wprzytula approved these changes

@muzarski muzarski muzarski approved these changes

Assignees

@sylwiaszunejko sylwiaszunejko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sylwiaszunejko @wprzytula @muzarski