Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dm/folder structure #1217

Open
wants to merge 1 commit into
base: branch-hackathon
Choose a base branch
from

Conversation

CodeLieutenant
Copy link

@CodeLieutenant CodeLieutenant commented Feb 10, 2025

Replaced all mod utils; in favour of mod common
to unify the import and remove the magic #[path]
and not rely on it too much (allows copy paste);

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Feb 10, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: a75f79f

@CodeLieutenant CodeLieutenant marked this pull request as ready for review February 11, 2025 12:04
@CodeLieutenant CodeLieutenant changed the base branch from main to branch-hackathon February 11, 2025 12:05
Replaced all `mod utils;` in favour of `mod common`
to unify the import and remove the magic `#[path]`
and not rely on it too much (allows copy paste);

Signed-off-by: Dusan Malusev <[email protected]>
@Lorak-mmk
Copy link
Collaborator

There is actually no need to edit all the tests.
Remove pub(crate) use utils::*; from scylla/tests/common/mod.rs
Add pub(crate) use common::utils; to scylla/tests/integration/main.rs after mod common;

Then the tests will be able to just import utils mod like before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants