-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partitioner visibility #1223
Merged
wprzytula
merged 4 commits into
scylladb:branch-hackathon
from
wprzytula:partitioner-visibility
Feb 11, 2025
Merged
Partitioner visibility #1223
wprzytula
merged 4 commits into
scylladb:branch-hackathon
from
wprzytula:partitioner-visibility
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons to do so. First, users may be interested which partitioner is used for a specific PreparedStatement. Second, tests in session_test.rs call `get_partitioner_name()` to assert some things. If we want to extract `session_test.rs` to integration tests directory - out of `scylla` crate - we must therefore expose `get_partitioner_name(). NOTE: PartitionerHasherAny is made `pub` in this commit. This is a temporary measure. This is needed because otherwise the compiler errors out that we leak a crate-private type in public interface (the associated type in `impl Partitioner for PartitionerName`). We will be able to revert this once we unpub `Partitioner(Hasher)`.
As `PartitionerName` is now public and retrievable from `PreparedStatement` using `get_partitioner_name()`, it makes sense to accept it in `calculate_token_for_partition_key` instead of an `impl Partitioner` generic parameter.
We do not expect users to implement their own Partitioners nor use their methods. Therefore, `Partitioner` trait and its implementors, `Murmur3Partitioner` and `CDCPartitioner`, are made `pub(crate)`. Same with `PartitionerHasher` trait and its implementors.
See the following report for details: cargo semver-checks output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #1222.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.