Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session_test.rs: Move some tests to integration #1224

Conversation

sylwiaszunejko
Copy link
Contributor

@sylwiaszunejko sylwiaszunejko commented Feb 11, 2025

Tests that require a running cluster should be in integration tests.

This PR moves some of such tests from session_test.rs. Not all, because two of them use

pub(crate) fn serialize_values(
&self,
values: &impl SerializeRow,
) -> Result<SerializedValues, SerializationError> {
let ctx = RowSerializationContext::from_prepared(self.get_prepared_metadata());
SerializedValues::from_serializable(&ctx, values)
}
}
that is not publicly available.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@sylwiaszunejko sylwiaszunejko self-assigned this Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: d263226

@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_move_session_test branch from 54a76e3 to 53830ed Compare February 11, 2025 12:32
@sylwiaszunejko sylwiaszunejko force-pushed the hackathon_move_session_test branch from 53830ed to d263226 Compare February 11, 2025 12:40
@wprzytula wprzytula merged commit 73beaa3 into scylladb:branch-hackathon Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants