ccm: Make 'opts' parameter of the 'stop' method be optional #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will allow to use the 'stop' method just providing "None" parameter: ... .stop(None).await;
|
|
muzarski
approved these changes
Feb 12, 2025
| @@ -174,6 +174,7 @@ impl NodeStartOptions { | |||
| /// Options to stop the node with. | |||
| /// It allows to control the value of `--no-wait` and `--not-gently` ccm options. | |||
| #[allow(dead_code)] | |||
| #[derive(Default)] | |||
There was a problem hiding this comment.
Both booleans will be set to false. This is expected, right?
There was a problem hiding this comment.
Right, the same as in the new is expected.
Lorak-mmk
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow to use the 'stop' method just providing "None" parameter:
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.