Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python & Django upgrade #3

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Conversation

SunnyR
Copy link
Member

@SunnyR SunnyR commented Jun 7, 2024

@SunnyR SunnyR self-assigned this Jun 7, 2024
@SunnyR SunnyR requested a review from RouganStriker June 7, 2024 03:36
Copy link
Member

@RouganStriker RouganStriker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we need to drop the crisp-form code? I know it is not a feature we use but it would be nice to minimize the changes we make to the repo.

@SunnyR
Copy link
Member Author

SunnyR commented Jun 7, 2024

Did we need to drop the crisp-form code? I know it is not a feature we use but it would be nice to minimize the changes we make to the repo.

The crisp code fails a bunch of tests around rendering bootstrap3 html. The upstream repo has those failing tests as well in 1.0.0.dev1, so since we don't use it I dropped it. Another reason was to reduce the dependencies this project would have.

@RouganStriker
Copy link
Member

Did we need to drop the crisp-form code? I know it is not a feature we use but it would be nice to minimize the changes we make to the repo.

The crisp code fails a bunch of tests around rendering bootstrap3 html. The upstream repo has those failing tests as well in 1.0.0.dev1, so since we don't use it I dropped it. Another reason was to reduce the dependencies this project would have.

Gotcha, if its too much effort let's skip it. Could we just make a note on the readme that we dropped the crispy form in our fork?

@SunnyR
Copy link
Member Author

SunnyR commented Jun 7, 2024

Did we need to drop the crisp-form code? I know it is not a feature we use but it would be nice to minimize the changes we make to the repo.

The crisp code fails a bunch of tests around rendering bootstrap3 html. The upstream repo has those failing tests as well in 1.0.0.dev1, so since we don't use it I dropped it. Another reason was to reduce the dependencies this project would have.

Gotcha, if its too much effort let's skip it. Could we just make a note on the readme that we dropped the crispy form in our fork?

Updated the readme to include changes made in the fork.

Copy link
Member

@RouganStriker RouganStriker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 changes look good to me

@SunnyR SunnyR merged commit ea552cd into master Jun 7, 2024
1 check passed
@SunnyR SunnyR deleted the feature/devop-6780/python-django-upgrade branch June 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants