Ran tests for Django 5.0, updated tests to include new area-invalid t… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wanted to use it for Django >5.0
Tests failed for Django >5.0, but was just a slight change in the returned HTML injected by Django in an invalid form and not an apparent breaking change.
Updated the test to reflect this change in Django >5.0 while keeping the test valid for Django <5.0 without the aria-invalid field.
Generally tested this version in my project and appears to work well, at least doesn't crash anything (yet).
I'd give it the "It works on my machine" quality control ranking.