fibi v1.0.1 (solution: fixed subtitle) #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add a new interface method extractSubtitleUrlfromHtml() take two string parameters, html and videoId
I updated the parseSubtitlesInfo method and change the xmlUrl
sealedtx
reviewed
Nov 26, 2023
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| java-youtube-downloader | |||
| ============ | |||
|
|
|||
| [](https://jitpack.io/#sealedtx/java-youtube-downloader) | |||
| [](https://jitpack.io/#heisfibi/java-youtube-downloader) | |||
There was a problem hiding this comment.
please fix README.md to keep it as in target branch
sealedtx
reviewed
Nov 26, 2023
| <!-- text --> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-text</artifactId> |
There was a problem hiding this comment.
Can you implement StringEscapeUtils.unescapeJava() inside this project to avoid extra dependency?
sealedtx
reviewed
Nov 26, 2023
| @@ -59,7 +60,8 @@ public Response<VideoInfo> parseVideo(RequestVideoInfo request) { | |||
|
|
|||
| private VideoInfo parseVideo(String videoId, YoutubeCallback<VideoInfo> callback) throws YoutubeException { | |||
| // try to spoof android | |||
| // workaround for issue https://github.com/sealedtx/java-youtube-downloader/issues/97 | |||
| // workaround for issue | |||
sealedtx
reviewed
Nov 26, 2023
| @@ -46,7 +46,8 @@ public ParserImpl(Config config, Downloader downloader, Extractor extractor, Cip | |||
| public Response<VideoInfo> parseVideo(RequestVideoInfo request) { | |||
| if (request.isAsync()) { | |||
| ExecutorService executorService = config.getExecutorService(); | |||
| Future<VideoInfo> result = executorService.submit(() -> parseVideo(request.getVideoId(), request.getCallback())); | |||
| Future<VideoInfo> result = executorService | |||
sealedtx
reviewed
Nov 26, 2023
| @@ -129,7 +130,8 @@ private VideoInfo parseVideoWeb(String videoId, YoutubeCallback<VideoInfo> callb | |||
|
|
|||
| Response<String> response = downloader.downloadWebpage(new RequestWebpage(htmlUrl)); | |||
| if (!response.ok()) { | |||
| YoutubeException e = new YoutubeException.DownloadException(String.format("Could not load url: %s, exception: %s", htmlUrl, response.error().getMessage())); | |||
| YoutubeException e = new YoutubeException.DownloadException( | |||
|
@heisfibi Thank you for your work. I've left some comments. There are a lot of lines changed in [ParserImpl.java] due to formatting settings, can you fix it, so changes will represent only actual changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release, version fibi 1.0.0, is dedicated to resolving a critical issue related to caption generation that remained unaddressed in the original version 3.2.3. I'm pleased to announce that this issue has now been successfully resolved, offering a more robust and reliable solution.
One of the notable improvements in this release is the fix for the caption generation problem that users encountered in version 3.2.3. We've diligently worked to identify and rectify the root cause, ensuring a seamless experience for users who rely on captioning functionality.
What sets this release apart is its ability to address the caption generation issue without requiring the use of an API key. We understand the importance of simplifying the user experience and have streamlined the captioning process, eliminating the need for users to manage API keys. This enhancement not only makes the software more user-friendly but also reduces potential friction in the setup and configuration process.
As always, we remain committed to delivering high-quality software and addressing user feedback promptly. Users can now enjoy an improved captioning feature, and we look forward to continuing to enhance and refine this labrary in future releases.