Allow passing custom configuration to parse_headers
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gootorov
force-pushed
the
headers-with-cfg
branch
from
93edcf9 to
be2aeca
Compare
|
Friendly ping! :) |
|
@seanmonstar Apologies for pinging again. Do you mind having a look at this PR? This is a small, non-breaking change. Having this merged would be really great, if possible. If there's something that needs to be changed, such as documentation, tests, etc -- please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several protocols that look almost identical to HTTP (in my case, it is SIP). Often the only difference is the
request-lineand/or theresponse-line. In SIP in particular, multiline headers are the norm (allow_obsolete_multiline_headers_in_responses).Being able to parse the
request/response-lineby myself and then usingparse_headerswith a custom configuration would be very convenient.