Fixing cancel method and tests (#65)

Co-authored-by: Sean Thomas Burke <[email protected]>

src/assets/sitemapper.js

@@ -101,8 +101,8 @@ export default class Sitemapper {
     };
 
     return new Promise((resolve) => {
-      const requester = got(url, requestOptions)
-        .then((response) => {
+      const requester = got(url, requestOptions);
+        requester.then((response) => {
           if (!response || response.statusCode !== 200) {
             clearTimeout(this.timeoutTable[url]);
             return resolve({ error: response.error, data: response });

src/tests/test.es5.js

@@ -121,6 +121,21 @@ describe('Sitemapper', function () {
           done(error);
         });
     });
+
+    it('https://www.golinks.io/sitemap.xml sitemaps should return an empty array when timing out', function (done) {
+      this.timeout(30000);
+      const url = 'https://www.golinks.io/sitemap.xml';
+      sitemapper.timeout = 1;
+      sitemapper.fetch(url)
+        .then(data => {
+          data.sites.should.be.Array;
+          done();
+        })
+        .catch(error => {
+          console.error('Test failed');
+          done(error);
+        });
+    });
   });
 
   describe('getSites method', function () {

src/tests/test.js

@@ -30,14 +30,14 @@ describe('Sitemapper', function () {
       sitemapper.fetch.should.be.Function;
     });
 
-    it('should contruct with a url', () => {
+    it('should construct with a url', () => {
       sitemapper = new Sitemapper({
         url: 'google.com',
       });
       sitemapper.url.should.equal('google.com');
     });
 
-    it('should contruct with a timeout', () => {
+    it('should construct with a timeout', () => {
       sitemapper = new Sitemapper({
         timeout: 1000,
       });
@@ -121,6 +121,21 @@ describe('Sitemapper', function () {
           done(error);
         });
     });
+
+    it('https://www.golinks.io/sitemap.xml sitemaps should return an empty array when timing out', function (done) {
+      this.timeout(30000);
+      const url = 'https://www.golinks.io/sitemap.xml';
+      sitemapper.timeout = 1;
+      sitemapper.fetch(url)
+        .then(data => {
+          data.sites.should.be.Array;
+          done();
+        })
+        .catch(error => {
+          console.error('Test failed');
+          done(error);
+        });
+    });
   });
 
   describe('getSites method', function () {

src/tests/test.ts.ts

@@ -123,6 +123,22 @@ describe('Sitemapper', function () {
           done(error);
         });
     });
+
+    it('https://www.golinks.io/sitemap.xml sitemaps should return an empty array when timing out', function (done) {
+      this.timeout(30000);
+      const url = 'https://www.golinks.io/sitemap.xml';
+      sitemapper.timeout = 1;
+
+      sitemapper.fetch(url)
+        .then(data => {
+          data.sites.should.be.Array;
+          done();
+        })
+        .catch(error => {
+          console.error('Test failed');
+          done(error);
+        });
+    });
   });
 
   describe('getSites method', function () {