Fdv cas 471 postion admin #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Francesco, greetings from Thailand. Thanks for making this pull, looks like you spotted one bug and also added pole star run ci scripts. Could you possibly make a pull just for the bug fix. I have slightly different ways of releasing this library. I shall be putting it up on pip regularly though. If you give me a new pull with the bug fix can put it up today. |
|
(Oh another bit, the run ci scripts you put up reference devops General scripts, would be lovely to see these open source ;) ) P.s. Used to be that libraries referenced a different devops General script. I guess things have changed a bit... |
|
Hi Seb, long time no see, hope you're well :) I will update the PR ASAP, stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.