-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement on error reporting of 'for await' loops #189
Conversation
Ooops, looks like this needs some more work: af79159#diff-92a67081d35facbe8921de0638d8eccd7f7204c8b99a656abc3af2ea750857c1R3045-R3055 Please don't merge this yet. |
src/Esprima/JavascriptParser.cs
Outdated
@@ -41,7 +41,7 @@ public Context() | |||
public bool AllowIn; | |||
public bool AllowStrictDirective; | |||
public bool AllowYield; | |||
public bool Await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even thought might not seem a good name, I think we should keep the naming that JS project has to make diffing and syncing easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I'll revert it.
@lahma Ok, I went over it again, I think it's ready now. Update: I squashed the corrections into the main commit to make it easier to review. |
I think we should wait for the Esprima change first, it also renames the |
Hey @adams85 I think we've forgotten this one, could you rebase? 🙂 |
Fixed the conflict from the GH UI, hopefully correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's all good, might need some styling adjustment later on but test cases are covering now 👍🏻
A minor fix related to async iterations (see #183 (comment))