refactor: ♻️ delete whole references folder pre and post render #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Aug 13, 2025
| @@ -1,7 +1,7 @@ | |||
| project: | |||
| type: website | |||
| # Delete auto-generated files from `quartodoc` | |||
| post-render: rm -f docs/reference/*.qmd | |||
There was a problem hiding this comment.
This wasn't deleting the files for me for some reason.
There are also other files in the folder -- I'm assuming all can be deleted as we're not tracking this folder?
There was a problem hiding this comment.
I've tested that quarto doesn't seem to use rm. So we could move the deletion outside of quarto 😌
There was a problem hiding this comment.
Wait so the new version doesn't work for you either?
|
Fyi, since this changes files in the template folder, it would be refactor or fix (or feat) 😌 |
lwjohnst86
changed the title
martonvago
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the pre and post render steps delete the whole
referencesfolder, not just theqmdfiles.This PR needs a quick review.
Checklist
just run-all