-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Report Content Event
to customerio destination
#2650
base: main
Are you sure you want to change the base?
Conversation
hi @karngyan thanks for raising this PR. Do you work for Customer.io? If so could you please email me from a work email to [email protected] so I can verify your email address? If you don't work for Customer.io I'll have to reach out to them to have them review the PR as well. Kind regards, |
Hi again @karngyan , The CI / Validate check is failing. Could you please run To help me understand the use-case for this PR a little, could you share information of the API docs for sending a "Report Content Event" request to Customer.io please? I want to ensure that any conventions with the other pre-existing Actions are continued with this new code. Best regards, |
Hi @joe-ayoub-segment 👋 Thank you for reviewing the PR! Yes, I work at Customer.io. I’ll send you an email from my work address shortly for verification. I’ll run yarn types and update the PR. Regarding the documentation, this is a relatively new feature available to a select group of users. I’ll reach out to our docs team to get the link for you - please give me a little time. It's okay to delay this merge a little. Thanks, |
Just FYI we're going into a deploy freeze for the Xmas and New Years holidays, so this PR won't go out until the New Year. |
title: 'Report Content Event', | ||
description: 'Report a Viewed or Clicked Content event.', | ||
defaultSubscription: 'event = "Report Content Event"', | ||
fields: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @karngyan I just a had a quick look at some of the other Actions for this Destination.
There's an Action called 'Track Event' which looks similar to this new one you are adding. However it also has some additional fields which this new Action does not have.
- Person ID
- Event Name
- Event ID
I don't know anything about Customer.io, but would like to ensure that changes to the Integration are done in a consistent way. Should this new Action also have the aforementioned fields?
Best regards,
Joe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joe
Here's more info about Report Content Event: https://docs.customer.io/api/cdp/#section/Semantic-events/Report-content-event-(anonymous-in-app-activity)
{ | ||
name: 'Report Content Event', | ||
subscribe: 'event = "Report Content Event"', | ||
partnerAction: 'reportContentEvent', | ||
mapping: defaultValues(reportContentEvent.fields), | ||
type: 'automatic', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth having 2 separate Presets, one for viewed_content and one for clicked_content.
Each preset would need to set the value of the 'Action Type' field accordingly.
Report Content Event
to customerio destination.Track Event
.Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.