Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketo] - Add MultiStatus Support #2653

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Dec 17, 2024

This PR adds MultiStatus support to Marketo destination.

Testing

Testing in progress

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 19.71831% with 57 lines in your changes missing coverage. Please review.

Project coverage is 78.19%. Comparing base (4910fb0) to head (9fd0390).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...src/destinations/marketo-static-lists/functions.ts 15.38% 54 Missing and 1 partial ⚠️
...stinations/marketo-static-lists/addToList/index.ts 66.66% 1 Missing ⚠️
...tions/marketo-static-lists/removeFromList/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
- Coverage   78.38%   78.19%   -0.20%     
==========================================
  Files        1030     1032       +2     
  Lines       18393    18617     +224     
  Branches     3487     3522      +35     
==========================================
+ Hits        14418    14558     +140     
- Misses       2817     2883      +66     
- Partials     1158     1176      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Varadarajan V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants