-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: update VWO SmartCode to version 2.1 #2654
base: main
Are you sure you want to change the base?
update: update VWO SmartCode to version 2.1 #2654
Conversation
Thanks for raising this PR @zeeshan-vwo . |
Hi @joe-ayoub-segment, New unit tests are not required. Please find the screenshot of the tests below: |
hi @zeeshan-vwo thank you - I should have been clearer. It's OK that there's no unit tests, however I was asking if there's a way to demonstrate that this change won't break anything for customers who are already using the Integration. |
Hi @joe-ayoub-segment, our team has already tested it in the existing integrations. You can go ahead and merge the change. |
hi @zeeshan-vwo there are some failing CI checks |
hi @joe-ayoub-segment I have fixed the missing declarations and type check, now it will work in node environment as well. |
This PR updates the VWO SmartCode in the project to version 2.1, replacing the outdated version to ensure compatibility with VWO’s latest features and improvements. The update is backward-compatible, with testing successfully completed in a local environment. No new test cases are required.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.