-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAIN] [STRATCONN] Intercom web custom inbox button selector #2660
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
===========================================
- Coverage 78.40% 33.14% -45.27%
===========================================
Files 1032 14 -1018
Lines 18564 694 -17870
Branches 3517 114 -3403
===========================================
- Hits 14555 230 -14325
+ Misses 2833 464 -2369
+ Partials 1176 0 -1176 ☔ View full report in Codecov by Sentry. |
It would be good it there was some way of passing any of the Intercom boot items here - e.g. |
Hello @ChrisSargent, Thank you for your suggestion. We will address this in a separate PR shortly. Please let us know if you have any other suggestions that could be helpful. |
Perhaps allowing an option for us to prevent Segment making the boot call, so we could make the boot call ourselves would be more scaleable to be honest. |
A summary of your pull request, including the what change you're making and why.
Fixed the issue of the intercom custom inbox button selector; as per the intercom latest documents, we need to send
custom_launcher_selector
in intercomSettings.JIRA TICKETS: https://segment.atlassian.net/browse/STRATCONN-5306
Testing
Tested successfully on stage, its working fine.
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.