[STRATCONN-4101 & STRATCONN - 4099] Update Amazon Ads normalisation #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
+ Coverage 78.40% 78.41% +0.01%
==========================================
Files 1032 1032
Lines 18564 18574 +10
Branches 3517 3519 +2
==========================================
+ Hits 14555 14565 +10
+ Misses 2833 2832 -1
- Partials 1176 1177 +1 ☔ View full report in Codecov by Sentry. |
3 tasks
| // Define allowed character patterns | ||
| const alphanumeric = /[^a-z0-9]/g | ||
| const emailAllowed = /[^a-z0-9.@-]/g | ||
| const nonDigits = /[^\d]/g |
There was a problem hiding this comment.
Does this strip all leading zeros? Is that a requirement? Just checking as it is called out in here.
There was a problem hiding this comment.
No @varadarajan-tw it does not .As per this amazon format hashing ,They have specified removing leading or trailing whitespaces ,not zeroes. But yes it is mentioned in ticket.
varadarajan-tw
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the normalisation and hashing methods to align with the amazon ads data format requirements. https://advertising.amazon.com/help/GCCXMZYCK4RXWS6C
Jira Tickets:
Email normalisation
Phone Normalisation
Tested it locally and Staging.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.