Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on adding multistatus support on amazon-amc #2663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Dec 27, 2024

This Pull request is to add multiStatusResponse in Amazon AMC.
JIRA TICKET:- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-5314
Tested it in staging successfully.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 93.67089% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (3ea984b) to head (4c54679).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...on-actions/src/destinations/amazon-amc/function.ts 93.50% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   78.38%   78.43%   +0.04%     
==========================================
  Files        1030     1033       +3     
  Lines       18393    18602     +209     
  Branches     3487     3523      +36     
==========================================
+ Hits        14418    14590     +172     
- Misses       2817     2833      +16     
- Partials     1158     1179      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants