Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sendgrid lists] - multistatus responses #2664

Merged
merged 13 commits into from
Jan 9, 2025

Conversation

joe-ayoub-segment
Copy link
Contributor

Multi-status responses for SendGrid Lists Destination.

Testing

Includes unit tests.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 67.85714% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (3ea984b) to head (2c04d2a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...tinations/sendgrid-audiences/syncAudience/utils.ts 67.27% 25 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2664      +/-   ##
==========================================
- Coverage   78.38%   78.35%   -0.04%     
==========================================
  Files        1030     1032       +2     
  Lines       18393    18596     +203     
  Branches     3487     3523      +36     
==========================================
+ Hits        14418    14570     +152     
- Misses       2817     2850      +33     
- Partials     1158     1176      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor Author

Tested with multiple Audiences
image

@joe-ayoub-segment joe-ayoub-segment merged commit 3a377ae into main Jan 9, 2025
12 of 14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the sendgrid-lists-multistatus branch January 9, 2025 12:00
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants