Normalize email addresses for Google Enhanced Conversions #2668
+127
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rocket Mortgage is experiencing an issue with low match rates for Google Enhanced Conversions. Although the data is being sent successfully, the match rate is below 1%.
During troubleshooting, we identified that email addresses are not being normalized according to Google’s specifications when using the endpoint. While this discrepancy is unlikely to fully explain the low match rate, it is an issue worth addressing since normalization is outlined as a requirement in both our documentation and Google’s documentation.
Testing
hashing currently
hashing with this PR
Note
There is currently a failing test for
userLists
. I didn't touch any of the functionality here, as this is also failing in main.