Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linter and fix linting issues #2737

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Upgrade linter and fix linting issues #2737

merged 1 commit into from
Feb 13, 2025

Conversation

sayan-das-in
Copy link
Contributor

This PR updates the linter in Actions Destination which is a pre-requisite towards upgrading Node Upgrade from v18 to v22.

Testing

Tested locally and with unit tests.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@078cbaa). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2737   +/-   ##
=======================================
  Coverage        ?   79.21%           
=======================================
  Files           ?     1284           
  Lines           ?    24713           
  Branches        ?     5114           
=======================================
  Hits            ?    19576           
  Misses          ?     3926           
  Partials        ?     1211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sayan-das-in sayan-das-in merged commit 9c96f4c into main Feb 13, 2025
14 checks passed
@sayan-das-in sayan-das-in deleted the upgrade-linter branch February 13, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants