Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Default version to v21 in Facebook Conversion API #2740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Feb 13, 2025

Clean up and Rollout out of v20.0 APIs:#2720
This PR is to set Default Version to V21 .
Jira ticket :- https://segment.atlassian.net/browse/STRATCONN-5408

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner February 13, 2025 09:50
@Innovative-GauravKochar Innovative-GauravKochar changed the title Set Default version to V21 in Facebook Conversion API Set Default version to v21 in Facebook Conversion API Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@078cbaa). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2740   +/-   ##
=======================================
  Coverage        ?   78.49%           
=======================================
  Files           ?     1036           
  Lines           ?    18798           
  Branches        ?     3571           
=======================================
  Hits            ?    14756           
  Misses          ?     2837           
  Partials        ?     1205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants