Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert exec() output to string #239

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Convert exec() output to string #239

merged 1 commit into from
Jan 15, 2025

Conversation

JeroenBakker
Copy link
Contributor

Fixes #238

Convert the exec output to string
ccdd6fb 
exec outputs an array of lines, handleError() only accepts strings.
This causes a TypeError due to strict_types, and is very hard to debug.
@MichaelGHSeg MichaelGHSeg merged commit 3fe22ea into segmentio:master Jan 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelGHSeg MichaelGHSeg MichaelGHSeg approved these changes

@nd4p90x nd4p90x nd4p90x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consumer::handleError() TypeError for ForkCurl queue consumer
3 participants
@JeroenBakker @nd4p90x @MichaelGHSeg