-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: update VWO SmartCode to version 2.1 #808
update: update VWO SmartCode to version 2.1 #808
Conversation
025e7ae
to
84ca64b
Compare
The VWO SmartCode v2.1 script when it gets executed auto-detects (detecting first-contentful-paint Ref: PerformancePaintTiming - Web APIs | MDN) if the page is already loaded then it prevents the page (body) from hiding from it. Attached is the videos demonstrating the testing process. To replicate the scenario of asynchronously adding the Smartcode, the Smartcode is loaded 2 seconds after the page load using setTimeout within the script tag. Additionally, I conducted A/B tests to check for flickering across different variations. No flickering issues were detected during these tests. Please refer to the attached video for reference. Video - SmartCode Async Test Variation - 1, Original Content, No white flicker detected SmartCode.Async.Test.Variation.-.1.movSmartCode.Async.Test.Variation-2.mov |
This reverts commit f521d3a.
What does this PR do?
This PR updates the VWO SmartCode in the project to the latest version (v2.1), replacing the outdated version to ensure compatibility and access to the latest features and improvements.
Are there breaking changes in this PR?
No, there are no breaking changes expected in this PR. The updated SmartCode is backward-compatible with existing functionality.
Testing Plan:
Testing not required
Any background context you want to provide?
The current project contains a very old version of the VWO SmartCode. Upgrading to version 2.1 ensures alignment with VWO’s latest updates and feature set.
Is there parity with the server-side/android/iOS integration components (if applicable)?
This PR is not directly related to server-side, Android, or iOS components.
Does this require a new integration setting? If so, please explain how the new setting works
No new integration settings are required for this update.