Add support for location attributes in Attio #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently made a backend change to support locations as a plain string, this commit updates the docs to clarify this.
nickcampbell18
requested review from
forstisabella
and removed request for
a team
forstisabella
approved these changes
Nov 30, 2023
Co-authored-by: forstisabella <[email protected]>
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hi folks! We've recently added an address parser to the Attio API so we can now accept location data. Since all these attributes are cast down to strings, it accepts a string containing mixed location data and converts it back into structured data internally (it doesn't really matter about ordering of parts, or punctuation, these are stripped out when the parser runs).
Here's an example from the mappings we use for our Segment instance:
Do you think there is any further guidance we should provide here?
Merge timing